Skip to content

[Testing] Enable cover block uploads behind dev flag #13769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mkevins wants to merge 1 commit into from
Closed

[Testing] Enable cover block uploads behind dev flag #13769

mkevins wants to merge 1 commit into from

Conversation

@mkevins
Copy link
Contributor

@mkevins mkevins commented Mar 30, 2020

Description

This PR is the first step toward resolving wordpress-mobile/gutenberg-mobile#1739. This PR enables upload options for the Cover block behind the __DEV__ flag, and adds a progress bar to ongoing uploads. More details can be found within the individual gutenberg PRs.

Related PRs:

To test:

Testing steps are provided in the related gutenberg PRs.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@mkevins mkevins added Media [Status] DO NOT MERGE Gutenberg Editing and display of Gutenberg blocks. labels Mar 30, 2020
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Mar 30, 2020 •
edited
Loading

Warnings
⚠️ This PR is tagged with 'DO NOT MERGE'.
⚠️ PR is not assigned to a milestone.

Generated by 🚫 dangerJS

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Mar 30, 2020 •
edited
Loading

You can test the changes on this Pull Request by downloading it from AppCenter here with build number: 26584. IPA is available here. If you need access to this, you can ask a maintainer to add you.

@github-actions
Copy link

github-actions bot commented Mar 30, 2020

Warnings
⚠️ This PR is tagged with 'DO NOT MERGE'.

Generated by 🚫 dangerJS against 4c3f91a

This was referenced Mar 30, 2020
Merged
Merged
Merged
Merged
@SergioEstevao
Copy link
Contributor

SergioEstevao commented Apr 6, 2020

@mkevins do we need to implement a background upload processor specific for this block?

@mkevins
Copy link
Contributor Author

mkevins commented Apr 22, 2020

For posterity: processors are implemented here: #13928

@mkevins mkevins closed this Apr 22, 2020
@mkevins mkevins deleted the feature/cover-block-uploads branch April 22, 2020 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Gutenberg Editing and display of Gutenberg blocks. Media [Status] DO NOT MERGE

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mkevins @SergioEstevao